Maor Lipchuk has posted comments on this change.
Change subject: core: improve CDA of AddStorageServerConnection
......................................................................
Patch Set 3: (1 inline comment)
Looks good, minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
Line 66: }
Line 67:
Line 68: @Override
Line 69: protected boolean canDoAction() {
Line 70: if(super.canDoAction()) {
Consider to use negative condition here, so it will just return false when the
super CDA will return false.
Also use the formatter on the if condition (add space between the if and the
call to super)
Line 71: StorageServerConnections paramConnection =
getParameters().getStorageServerConnection();
Line 72: if (paramConnection.getstorage_type() == StorageType.NFS
Line 73: && !new
NfsMountPointConstraint().isValid(paramConnection.getconnection(), null)) {
Line 74: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
--
To view, visit http://gerrit.ovirt.org/15126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00a46aac7d642128c287ef633c492f3c1b85f572
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
