Allon Mureinik has posted comments on this change.
Change subject: core: seat compensate - prevent IndexOutOfBounds
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 657: revertPreviousHandlers();
Line 658: }
Line 659: }
Line 660: else {
Line 661: setSucceeded(true);
consider flipping the if and else blocks, so you don't have a dangling on-liner
Line 662: }
Line 663: }
Line 664:
Line 665: protected void logRollbackedTask() {
Line 1833: private int getExecutionIndex() {
Line 1834: return getParameters().getExecutionIndex();
Line 1835: }
Line 1836:
Line 1837: private boolean canRevertTasks() {
s/canRevertTasks/hasStepsToRevert/
Line 1838: return getExecutionIndex() >= 0;
Line 1839: }
Line 1840:
Line 1841: public boolean isQuotaChanged() {
....................................................
Commit Message
Line 3: AuthorDate: 2013-05-26 11:03:59 +0300
Line 4: Commit: Daniel Erez <[email protected]>
Line 5: CommitDate: 2013-05-28 18:09:45 +0300
Line 6:
Line 7: core: seat compensate - prevent IndexOutOfBounds
s/seat/SEAT/
Line 8:
Line 9: CommandBase -> hasTaskHandlers:
Line 10: * compensate: setExecutionReason to ROLLBACK_FLOW
Line 11: for ensuring internalEndWithFailure flow
--
To view, visit http://gerrit.ovirt.org/15133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
