Allon Mureinik has posted comments on this change.
Change subject: core: SEAT compensate - prevent IndexOutOfBounds
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 657: revertPreviousHandlers();
Line 658: }
Line 659: }
Line 660: else {
Line 661: setSucceeded(true);
A matter of taste.
I personally hate dangling one-liners more.
Anyway, not biggie.
Line 662: }
Line 663: }
Line 664:
Line 665: protected void logRollbackedTask() {
--
To view, visit http://gerrit.ovirt.org/15133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches