Moti Asayag has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
......................................................................
Patch Set 13: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
Line 131: }
Line 132: return true;
Line 133: }
Line 134:
Line 135: private boolean properiesRequiringVmUpdateDeviceWereUpdated() {
although not related to this specific patch, note there is a typo in this
method name:
s/properies/propertiesRequiringVmUpdateDeviceWereUpdated
Line 136: return (!StringUtils.equals(oldIface.getNetworkName(),
getNetworkName()))
Line 137: || oldIface.isLinked() != getInterface().isLinked()
Line 138: ||
!StringUtils.equals(oldIface.getCustomProperties(),
getInterface().getCustomProperties());
Line 139: }
....................................................
Commit Message
Line 8:
Line 9: Patch contains:
Line 10:
Line 11: - Adds custom properties to VmNetworkInterface.
Line 12: - Add custom proerties validation and store to db ti
s/proerties/properties
ti ?
Line 13: Add/UpdateVm/TemplateInterfaceCommand.
Line 14: - Sending custom properties to VDS on RunVm, UpdateVmInterfaceDevice
and
Line 15: Plug.
Line 16:
--
To view, visit http://gerrit.ovirt.org/14815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I218db49043ddf0524178f6ff903e605bc0fe661a
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
