Yair Zaslavsky has posted comments on this change.
Change subject: core: Adds custom properties to VmNetworkInterface
......................................................................
Patch Set 18: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java
Line 81: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 82: @Override
Line 83: public Void runInTransaction() {
Line 84: getCompensationContext().snapshotEntity(oldIface);
Line 85: getVmNetworkInterfaceDao().update(getInterface());
Once again - no need to snapshotEnity of the oldVmDevice?
Line 86:
oldVmDevice.setCustomProperties(getInterface().getCustomProperties());
Line 87: getDbFacade().getVmDeviceDao().update(oldVmDevice);
Line 88: getCompensationContext().stateChanged();
Line 89: return null;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java
Line 65:
DevicePropertiesUtils.getInstance().validateProperties(version,
Line 66: VmDeviceGeneralType.INTERFACE,
Line 67: nic.getCustomProperties());
Line 68: if (!errors.isEmpty()) {
Line 69: VmHandler.handleCustomPropertiesError(errors, messages);
Ugly that this is in VmHandler, I would reconsider and move this to
CustomPropertiesUtils or something like that.
Line 70: return false;
Line 71: }
Line 72: return true;
Line 73: }
--
To view, visit http://gerrit.ovirt.org/14815
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I218db49043ddf0524178f6ff903e605bc0fe661a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
