Sahina Bose has uploaded a new change for review.

Change subject: gluster: Fixed Find bug error (possible NPE)
......................................................................

gluster: Fixed Find bug error (possible NPE)

Fixed possible NPE with vds.getName()

Change-Id: I18651a48a422970cfc16d8e844c34c52029570f3
Signed-off-by: Sahina Bose <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/15209/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
index efd038c..3bdcf9f 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
@@ -78,7 +78,7 @@
         for (GlusterServerHook serverHook: getContentConflictServerHooks()) {
             VDS vds = getVdsDAO().get(serverHook.getServerId());
             if (vds == null || vds.getStatus() != VDSStatus.Up) {
-                setVdsName(vds.getName() !=null ? vds.getName() : "NO SERVER");
+                setVdsName(vds != null ? vds.getName() : "NO SERVER");
                 
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_SERVER_STATUS_NOT_UP);
                 return false;
             }


--
To view, visit http://gerrit.ovirt.org/15209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I18651a48a422970cfc16d8e844c34c52029570f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to