Shahar Havivi has uploaded a new change for review. Change subject: findbugs: ignore: ENGINE_NETWORK_NAME is public static and not final ......................................................................
findbugs: ignore: ENGINE_NETWORK_NAME is public static and not final Change-Id: Icb499823d4dd320e8519682399858e15bff134a4 Signed-off-by: Shahar Havivi <[email protected]> --- A frontend/webadmin/modules/uicommonweb/exclude-filters.xml M frontend/webadmin/modules/uicommonweb/pom.xml 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/15286/1 diff --git a/frontend/webadmin/modules/uicommonweb/exclude-filters.xml b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml new file mode 100644 index 0000000..e9ed26e --- /dev/null +++ b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml @@ -0,0 +1,12 @@ +<FindBugsFilter> + <!-- + findbugs complain that ENGINE_NETWORK_NAME will be final, + We are initialize this variable in the constructor and it cannot be final. + + MS: Field isn't final and can't be protected from malicious code (MS_CANNOT_BE_FINAL) + --> + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel" /> + <Bug code="MS"/> + </Match> +</FindBugsFilter> diff --git a/frontend/webadmin/modules/uicommonweb/pom.xml b/frontend/webadmin/modules/uicommonweb/pom.xml index 24a9737..1e9d5f4 100644 --- a/frontend/webadmin/modules/uicommonweb/pom.xml +++ b/frontend/webadmin/modules/uicommonweb/pom.xml @@ -58,6 +58,17 @@ <propertyExpansion>runNlsCheck=true</propertyExpansion> </configuration> </plugin> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <version>${findbugs.version}</version> + <configuration> + <xmlOutput>true</xmlOutput> + <!-- Optional directory to put findbugs xdoc xml report --> + <excludeFilterFile>exclude-filters.xml</excludeFilterFile> + <xmlOutputDirectory>target/site</xmlOutputDirectory> + </configuration> + </plugin> </plugins> </build> -- To view, visit http://gerrit.ovirt.org/15286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb499823d4dd320e8519682399858e15bff134a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
