Alona Kaplan has posted comments on this change. Change subject: findbugs: ignore: ENGINE_NETWORK_NAME is public static and not final ......................................................................
Patch Set 5: I think you don't need this exclusion. You can use (String)AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.ManagementNetwork) in each of the places that use ENGINE_NETWORK_NAME. -- To view, visit http://gerrit.ovirt.org/15286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb499823d4dd320e8519682399858e15bff134a4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
