Vered Volansky has posted comments on this change.
Change subject: core: remove memory image on remove snapshot
......................................................................
Patch Set 15: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 146: }
Line 147: }).size() > 0;
Line 148:
Line 149: // delete first image
Line 150: // the next 'DeleteImageGroup' command should also take care
of the
I think what you mean is 'the following' and not 'the next'. Applies to the
next comment as well.
Also - code duplication between this section and the following one. Any reason
not to extract to a function?
Line 151: // image removal:
Line 152: VDSReturnValue vdsRetValue = runVdsCommand(
Line 153: VDSCommandType.DeleteImageGroup,
Line 154: new
DeleteImageGroupVDSCommandParameters(guids.get(1), guids.get(0), guids.get(2),
Line 150: // the next 'DeleteImageGroup' command should also take care
of the
Line 151: // image removal:
Line 152: VDSReturnValue vdsRetValue = runVdsCommand(
Line 153: VDSCommandType.DeleteImageGroup,
Line 154: new
DeleteImageGroupVDSCommandParameters(guids.get(1), guids.get(0), guids.get(2),
I would extract the specific guids to variables for readability and easier
maintenance.
Line 155: postZero, false,
getVm().getVdsGroupCompatibilityVersion().toString()));
Line 156:
Line 157: if (!vdsRetValue.getSucceeded()) {
Line 158: log.errorFormat("Cannot remove memory dump volume for
snapshot {0}", snapshot.getId());
--
To view, visit http://gerrit.ovirt.org/14687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a707457b3b1565a887e141d18d9d08a2dbcc69
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
