Allon Mureinik has posted comments on this change.
Change subject: core: remove memory image on remove snapshot
......................................................................
Patch Set 16: I would prefer that you didn't submit this
(1 inline comment)
Please add a DAO test, as per Omer's comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
Line 124: }
Line 125:
Line 126: /**
Line 127: * There is a one to many relation between memory volumes and
snapshots, so memory
Line 128: * volumes should be removed only if the only snapshot that
points to them is removed
Why is this?
What is the meaning of keeping the same memory volume for several snapshots?
Line 129: */
Line 130: private boolean shouldRemoveMemorySnapshotVolumes(String
memoryVolume) {
Line 131: return !memoryVolume.isEmpty() &&
Line 132:
getSnapshotDao().getNumOfSnapshotsByMemory(memoryVolume) == 1;
--
To view, visit http://gerrit.ovirt.org/14687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88a707457b3b1565a887e141d18d9d08a2dbcc69
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
