Yair Zaslavsky has posted comments on this change. Change subject: gluster: bll command to start/stop/restart service ......................................................................
Patch Set 4: (1 inline comment) You're introducing here a change to SP (you add two new functions) - why not having it in separate patch? I prefer bll patches to be "business logic" only, if possible. .................................................... File backend/manager/dbscripts/gluster_services_sp.sql Line 39: END; $procedure$ Line 40: LANGUAGE plpgsql; Line 41: Line 42: -- cluster-wide service given cluster id and service type Line 43: Create or replace FUNCTION GetGlusterClusterServicesByClusterIdAndServiceType(v_cluster_id UUID, v_service_type VARCHAR(100)) IMHO, Unecessary noise introduced by your editor, please fix that. Line 44: RETURNS SETOF gluster_cluster_services Line 45: AS $procedure$ Line 46: BEGIN Line 47: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/14831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcab38866c49c6f5d43e3b33006c428ec9304501 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
