Sahina Bose has posted comments on this change.
Change subject: gluster: bll command to start/stop/restart service
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(2 inline comments)
Minor comments inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
Line 175: }
Line 176: }
Line 177:
Line 178: private void performActionForServicesOfCluster() {
Line 179: List<Callable<Pair<VDS, VDSReturnValue>>> taskList =
getCallableVdsCmdList();
Minor - could rename to cmdList
Line 180:
Line 181: if (!taskList.isEmpty()) {
Line 182: invokeManageGlusterService(taskList);
Line 183: } else {
Line 195:
Line 196: setSucceeded(returnValue.getSucceeded());
Line 197:
Line 198: if (!getSucceeded()) {
Line 199:
handleVdsError(manageActionDetailsMap.get(getParameters().getActionType()).getActionFailedActionLog(),
Minor - can use getAuditLogTypeValue() here.
Line 200: returnValue.getVdsError().getMessage());
Line 201: } else {
Line 202: updateService(serverId, (List<GlusterServerService>)
returnValue.getReturnValue());
Line 203: }
--
To view, visit http://gerrit.ovirt.org/14831
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcab38866c49c6f5d43e3b33006c428ec9304501
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
