Eli Mesika has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 9: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 132: ordinal = rs2.getInt("ORDINAL_POSITION");
Line 133: } catch (SQLException e) {
Line 134: // For some reason, some postgres drivers
don't
Line 135: // provide
Line 136: // ORDINAL_POSITION
Please mark this code as "to be deleted " when using a 9.x driver
http://jdbc.postgresql.org/changes.html :
"fix Fix the ORDINAL_POSITION in the DatabaseMetaData.getColumns. Previously we
were returning simply pg_attribute.attnum, but that doesn't work in the
presence of dropped columns because later columns don't get their attnum
decremented if a preceding column is dropped. Instead use the row_number window
function for 8.4 and later servers to figure out the live column position.."
Line 137: ordinal = internalCounter;
Line 138: }
Line 139: int dataType = rs2.getInt("DATA_TYPE");
Line 140: procSchemaFromDB =
rs2.getString("PROCEDURE_SCHEM");
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
