Yair Zaslavsky has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/PostgresDbEngineDialect.java
Line 198:
Line 199: @Override
Line 200: public String createSqlCallCommand(String procSchemaFromDB,
Line 201: String procNameFromDB, StringBuffer params) {
Line 202: StringBuffer sqlCommand = new StringBuffer();
I agree here, we should use StringBuilder.
Line 203: sqlCommand.append("{call
").append(procSchemaFromDB).append(".")
Line 204:
.append(procNameFromDB).append("(").append(params).append(")}");
Line 205: return sqlCommand.toString();
Line 206: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java
Line 59: public void executeStoredProcAsBatch(final String procName,
Line 60: final List<MapSqlParameterSource> executions)
Line 61: throws DataAccessException {
Line 62:
Line 63: template.execute(new ConnectionCallback<Object>() {
+1 here.
Line 64:
Line 65: @Override
Line 66: public Object doInConnection(Connection con) throws
SQLException,
Line 67: DataAccessException {
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
