Laszlo Hornyak has posted comments on this change.

Change subject: engine: add comment field to DataCenter
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
Line 26:             message = "VALIDATION.DATA_CENTER.DESCRIPTION.INVALID",
Line 27:             groups = { CreateEntity.class, UpdateEntity.class })
Line 28:     private String description;
Line 29: 
Line 30:     private String comment;
I believe size validation does not make sense here.
Line 31: 
Line 32:     private int storagePoolType = StorageType.UNKNOWN.getValue();
Line 33: 
Line 34:     private StorageFormatType storagePoolFormatType = null;


--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to