Daniel Erez has posted comments on this change.
Change subject: engine: add comment field to DataCenter
......................................................................
Patch Set 5: (4 inline comments)
I think it's preferable to merge along with the other business entities (i.e.
only when the work is completed on all main tabs).
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
Line 26: message = "VALIDATION.DATA_CENTER.DESCRIPTION.INVALID",
Line 27: groups = { CreateEntity.class, UpdateEntity.class })
Line 28: private String description;
Line 29:
Line 30: private String comment;
add max size validation
Line 31:
Line 32: private int storagePoolType = StorageType.UNKNOWN.getValue();
Line 33:
Line 34: private StorageFormatType storagePoolFormatType = null;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java
Line 307: getVersion().validateSelectedItem(new IValidation[] { new
NotEmptyValidation() });
Line 308:
Line 309: getDescription().validateEntity(new IValidation[] { new
AsciiOrNoneValidation() });
Line 310:
Line 311: getComment().validateEntity(new IValidation[] { new
AsciiOrNoneValidation() });
any issue with I18N? I think it should be validated with
SpecialAsciiI18NOrNoneValidation
Line 312:
Line 313: // TODO: add this code to async validate.
Line 314: // string name = (string)Name.Entity;
Line 315: // if (String.Compare(name, OriginalName, true) != 0 &&
!DataProvider.IsDataCenterNameUnique(name))
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml
Line 12: <d:content>
Line 13: <g:FlowPanel>
Line 14: <e:EntityModelTextBoxEditor
ui:field="nameEditor" />
Line 15: <e:EntityModelTextBoxEditor
ui:field="descriptionEditor" />
Line 16: <e:EntityModelTextBoxEditor
ui:field="commentEditor" />
i guess it can be the last widget
Line 17: <e:ListModelListBoxEditor
ui:field="storageTypeListEditor" />
Line 18: <e:ListModelListBoxEditor
ui:field="versionEditor" />
Line 19: <e:ListModelListBoxEditor
ui:field="quotaEnforceTypeEditor" />
Line 20: </g:FlowPanel>
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/CommentColumn.java
Line 9: @Override
Line 10: public ImageResource getValue(T value) {
Line 11: setTitle(value.getComment());
Line 12: if (value.getComment() != null && value.getComment() != "") {
Line 13: // TODO Replace with a real image
already replaced..?
Line 14: return getApplicationResources().commentImage();
Line 15: }
Line 16: return null;
Line 17: }
--
To view, visit http://gerrit.ovirt.org/14878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4168a782074af1bbd5b89b5a0564b44cb301f82f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
