Shubhendu Tripathi has posted comments on this change.
Change subject: gluster:Support Striped_replicate volume types
......................................................................
Patch Set 2: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 41: if (getParameters().getBricks() == null ||
getParameters().getBricks().size() == 0) {
Line 42:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_BRICKS_REQUIRED);
Line 43: return false;
Line 44: }
Line 45: if (getGlusterVolume().getVolumeType() ==
GlusterVolumeType.REPLICATE
We can think of creating a list of enum values using
Arrays.asList(GlusterVolumeType.values()) and use contains for checking the
existence in the same list for getGlusterVolume()
Line 46: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_REPLICATE
Line 47: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.STRIPED_REPLICATE
Line 48: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_STRIPED_REPLICATE) {
Line 49: if (getParameters().getReplicaCount() >
getGlusterVolume().getReplicaCount() + 1) {
Line 51: } else if (getParameters().getReplicaCount() <
getGlusterVolume().getReplicaCount()) {
Line 52:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CAN_NOT_REDUCE_REPLICA_COUNT);
Line 53: }
Line 54: }
Line 55: if (getGlusterVolume().getVolumeType() ==
GlusterVolumeType.STRIPE
As above
Line 56: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_STRIPE
Line 57: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.STRIPED_REPLICATE
Line 58: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_STRIPED_REPLICATE) {
Line 59: if (getParameters().getStripeCount() >
getGlusterVolume().getStripeCount() + 1) {
Line 173: }
Line 174: }
Line 175:
Line 176: private boolean isStripeCountIncreased() {
Line 177: if ((getGlusterVolume().getVolumeType() ==
GlusterVolumeType.STRIPE
As above
Line 178: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_STRIPE
Line 179: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.STRIPED_REPLICATE
Line 180: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_STRIPED_REPLICATE)
Line 181: && getParameters().getStripeCount() >
getGlusterVolume().getStripeCount()) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
Line 416: return;
Line 417: }
Line 418:
Line 419: GlusterVolumeType selectedVolumeType = (GlusterVolumeType)
getTypeList().getSelectedItem();
Line 420: if (selectedVolumeType == GlusterVolumeType.REPLICATE
Switch-case can be used
Line 421: || selectedVolumeType ==
GlusterVolumeType.DISTRIBUTED_REPLICATE)
Line 422: {
Line 423:
getReplicaCount().setEntity(volumeBrickModel.getReplicaCount().getEntity());
Line 424: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 585: volume.setClusterId(clusterId);
Line 586: volume.setName((String) volumeModel.getName().getEntity());
Line 587: GlusterVolumeType type = (GlusterVolumeType)
volumeModel.getTypeList().getSelectedItem();
Line 588:
Line 589: if (type == GlusterVolumeType.STRIPE || type ==
GlusterVolumeType.DISTRIBUTED_STRIPE) {
May be switch-case can be used here
Line 590: volume.setStripeCount(volumeModel.getStripeCountValue());
Line 591: } else if (type == GlusterVolumeType.REPLICATE || type ==
GlusterVolumeType.DISTRIBUTED_REPLICATE) {
Line 592:
volume.setReplicaCount(volumeModel.getReplicaCountValue());
Line 593: } else if ( type == GlusterVolumeType.STRIPED_REPLICATE
--
To view, visit http://gerrit.ovirt.org/15381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517c1e9e41f1bb68626d5a8a45d679208934d98f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
