Shubhendu Tripathi has posted comments on this change.
Change subject: gluster:Support Striped_replicate volume types
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
Line 130:
Line 131: getTypeList().getSelectedItemChangedEvent().addListener(new
IEventListener() {
Line 132:
Line 133: @Override
Line 134: public void eventRaised(Event ev, Object sender,
EventArgs args) {
The below if conditions also can use enums.values to check the value of
selected item.
Line 135: if (getTypeList().getSelectedItem() ==
GlusterVolumeType.REPLICATE
Line 136: || getTypeList().getSelectedItem() ==
GlusterVolumeType.DISTRIBUTED_REPLICATE
Line 137: || getTypeList().getSelectedItem() ==
GlusterVolumeType.STRIPED_REPLICATE
Line 138: || getTypeList().getSelectedItem() ==
GlusterVolumeType.DISTRIBUTED_STRIPED_REPLICATE) {
--
To view, visit http://gerrit.ovirt.org/15381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517c1e9e41f1bb68626d5a8a45d679208934d98f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
