Allon Mureinik has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(3 inline comments)
There still seems to be quite a bit of formatting "noise" here - would be great
to have it cleaned up
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcExecutionConnectionCallback.java
Line 17: import org.springframework.jdbc.core.ConnectionCallback;
Line 18: import org.springframework.jdbc.core.namedparam.MapSqlParameterSource;
Line 19: import org.springframework.jdbc.core.simple.SimpleJdbcCall;
Line 20:
Line 21: public final class BatchProcExecutionConnectionCallback implements
ConnectionCallback<Object> {
I don't think we have a quota on how many characters we can use for a name :-)
s/Proc/Procedure/
Line 22: private static final Log log =
LogFactory.getLog(BatchProcExecutionConnectionCallback.class);
Line 23: private static ConcurrentMap<String, StoredProcedureMetaData>
storedProceduresMap =
Line 24: new ConcurrentHashMap<String, StoredProcedureMetaData>();
Line 25:
Line 65: }
Line 66: throw e;
Line 67: } finally {
Line 68: if (stmt != null)
Line 69: stmt.close();
why not use the Java7 autoclosable syntax?
Line 70: }
Line 71:
Line 72: return null;
Line 73: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbEngineDialect.java
Line 32: * @return A {@link SimpleJdbcCallOperations} instance that can be
used to
Line 33: * call a query function in the DB.
Line 34: */
Line 35: public SimpleJdbcCallOperations createJdbcCallForQuery(
Line 36: JdbcTemplate jdbcTemplate);
why all this formatting noise?
Line 37:
Line 38: /**
Line 39: * Gets the engine prefix to be used for sp parameters.
Line 40: * @return
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
