Liron Ar has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
......................................................................
Patch Set 21: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 137: return cachedStorageDomainId;
Line 138: }
Line 139:
Line 140: private MemoryImageBuilder createMemoryImageBuilder() {
Line 141: return
FeatureSupported.memorySnapshot(getVm().getVdsGroupCompatibilityVersion())
ignore, my mistake.
Line 142: && getParameters().isSaveMemory() &&
isLiveSnapshotApplicable() ?
Line 143: new DefaultMemoryImageBuilder(getVm(),
getStorageDomainIdForVmMemory(), getStoragePool(), this)
Line 144: : new NullableMemoryImageBuilder();
Line 145: }
Line 290:
Line 291: private SnapshotVDSCommandParameters
buildLiveSnapshotParameters(Snapshot snapshot) {
Line 292: List<Disk> pluggedDisks =
getDiskDao().getAllForVm(getVm().getId(), true);
Line 293: List<DiskImage> filteredPluggedDisks =
ImagesHandler.filterImageDisks(pluggedDisks, false, true);
Line 294: if
(FeatureSupported.memorySnapshot(getVm().getVdsGroupCompatibilityVersion())) {
ignore
Line 295: return new
SnapshotVDSCommandParameters(getVm().getRunOnVds().getValue(),
Line 296: getVm().getId(),
Line 297: filteredPluggedDisks,
Line 298: snapshot.getMemoryVolume());
--
To view, visit http://gerrit.ovirt.org/14291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb28efda1b63e506233a88399488a256e6ab1c8
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
