Liron Ar has posted comments on this change.
Change subject: core: save memory state on live snapshot with memory
......................................................................
Patch Set 21: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/DefaultMemoryImageBuilder.java
Line 64: "",
Line 65: storagePool.getcompatibility_version()
Line 66: .toString()));
Line 67:
Line 68: if (!retVal.getSucceeded()) {
exception would be thrown
Line 69: throw new VdcBLLException(VdcBllErrors.VolumeCreationError,
Line 70: "Failed to create image for vm configuration!");
Line 71: }
Line 72:
Line 71: }
Line 72:
Line 73: Guid guid =
enclosingCommand.createTask(retVal.getCreationInfo(),
Line 74: VdcActionType.CreateAllSnapshotsFromVm);
Line 75: enclosingCommand.getTaskIdList().add(guid);
I'd suggest to return the vds return value/creation info..and let the caller do
with that whatever it "wants".
Line 76: }
Line 77:
Line 78: private void createImageForMemoryDump() {
Line 79: VDSReturnValue retVal =
--
To view, visit http://gerrit.ovirt.org/14291
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbb28efda1b63e506233a88399488a256e6ab1c8
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
