Allon Mureinik has posted comments on this change.
Change subject: core: add validation to AddStorageServerConnection
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Minor issue - please see inline
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
Line 779:
Line 780: private void cleanConnection(StorageServerConnections connection,
Guid hostId) {
Line 781: // if create connection command was the one to fail and
didn't create a connection
Line 782: // then the id of connection will be empty, and there's
nothing to delete.
Line 783: if (connection.getid()!=null &&
!connection.getid().equalsIgnoreCase("")) {
there is no point in case sensitive check for an empty string.
Also, just use StringUtils.isEmpty(connection.getId())
Line 784:
Frontend.RunAction(VdcActionType.RemoveStorageServerConnection, new
StorageServerConnectionParametersBase(connection, hostId),
Line 785: null, this);
Line 786: }
Line 787:
--
To view, visit http://gerrit.ovirt.org/15388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9bcef8a413589654d36db8d878c844550ae6066
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
