Yair Zaslavsky has posted comments on this change.
Change subject: gluster: Host detach case sync message corrected
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
Line 133: }
Line 134: }
Line 135:
Line 136: private void removeDetachedServers(List<VDS> existingServers,
List<GlusterServerInfo> fetchedServers) {
Line 137: for (final VDS server : existingServers) {
why did you change to final here? should be outside of the scope of the patch.
Line 138: if (isRemovableStatus(server.getStatus()) &&
serverDetached(server, fetchedServers)) {
Line 139: log.debugFormat("Server {0} has been removed directly
using the gluster CLI. Removing it from engine as well.",
Line 140: server.getName());
Line 141: logUtil.logServerMessage(server,
AuditLogType.GLUSTER_SERVER_REMOVED_FROM_CLI);
--
To view, visit http://gerrit.ovirt.org/15177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2858ded9cfac2dc6df03928b90469876878aa94d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
