Tomas Jelinek has posted comments on this change.
Change subject: core: Use OS repository instead of VmOsType
......................................................................
Patch Set 18: (2 inline comments)
just two small comments
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1422: }
Line 1423:
Line 1424: private void initOSType() {
Line 1425: List<Integer> list = AsyncDataProvider.getAllVMsOsIds();
Line 1426: Collections.sort(list);
I would maybe provide a Comparator to sort according to the names of the OS and
not their IDs.
Line 1427:
Line 1428: getOSType().setItems(list);
Line 1429: getOSType().setSelectedItem(OsRepository.DEFAULT_OS);
Line 1430: }
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicDetailsView.java
Line 64: @Path("SelectedItem.Description")
Line 65: @WithElementId("description")
Line 66: Label vmDescription;
Line 67:
Line 68: @Ignore
still not convinced this should be ignored ;)
Line 69: @UiField
Line 70: @Path("SelectedItem.OsId")
Line 71: @WithElementId("os")
Line 72: ValueLabel operatingSystem;
--
To view, visit http://gerrit.ovirt.org/15078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
