Omer Frenkel has posted comments on this change.
Change subject: core: Use OS repository instead of VmOsType
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java
Line 75:
Line 76: @Before
Line 77: public void setUp() {
Line 78:
Line 79:
please remove these blank lines on your next rebase
Line 80: VmHandler.Init();
Line 81: vm = new VM();
Line 82: vmStatic = new VmStatic();
Line 83: group = new VDSGroup();
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml
Line 65: <include name="searchbackend/OsListAutoCompleter.java"
/>
Line 66: <include
name="searchbackend/SimpleDependencyInjector.java" />
Line 67:
<!--======================SEARCHBACKEND/GLUSTER====================== -->
Line 68: <include
name="searchbackend/gluster/GlusterVolumeConditionFieldAutoCompleter.java" />
Line 69: <include
name="searchbackend/gluster/GlusterVolumeCrossRefAutoCompleter.java" />
you didnt remove the duplication here
Line 70: <include
name="searchbackend/QuotaConditionFieldAutoCompleter.java" />
Line 71: <include
name="searchbackend/NetworkConditionFieldAutoCompleter.java" />
Line 72: <include
name="searchbackend/NetworkCrossRefAutoCompleter.java" />
Line 73: <include
name="searchbackend/NetworkInterfaceConditionFieldAutoCompleter.java" />
--
To view, visit http://gerrit.ovirt.org/15078
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I168225f20d567910cba861be75be87136926589f
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
