Yair Zaslavsky has posted comments on this change.
Change subject: 6. core: Persist all async task placeholders
......................................................................
Patch Set 13: (1 inline comment)
Ravi eliminated the checkCanDoAction
Please review the change
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1239: return annotation != null && annotation.forceCompensation();
Line 1240: }
Line 1241:
Line 1242: /**
Line 1243: * This method is called before executeAction and after
checkCanDoAction
The comment should be changed - no more checkCanDoAction :)
Line 1244: * to insert the async task place holders for the child commands.
Line 1245: */
Line 1246: protected void insertAsyncTaskPlaceHolders() {
Line 1247:
TransactionSupport.executeInScope(TransactionScopeOption.Required,
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
