Omer Frenkel has posted comments on this change.
Change subject: 6. core: Persist all async task placeholders
......................................................................
Patch Set 13: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1279: */
Line 1280: protected CommandBase<?> constructCommand(VdcActionType
actionType,
Line 1281: VdcActionParametersBase parameters,
Line 1282: boolean runAsInternal,
Line 1283: CommandContext context) {
i thought this should be private and call backend.createAction()
Line 1284: ExecutionHandler.evaluateCorrelationId(parameters);
Line 1285: CommandBase<?> command =
CommandsFactory.CreateCommand(actionType, parameters);
Line 1286: command.setInternalExecution(runAsInternal);
Line 1287: command.setContext(context);
Line 1294: * @param command
Line 1295: * @param parameters
Line 1296: * @return
Line 1297: */
Line 1298: protected VdcReturnValueBase runCommand(CommandBase<?> command) {
i thought this should be private and call backend.runAction(command)
Line 1299: VdcReturnValueBase returnValue = command.executeAction();
Line 1300:
returnValue.setCorrelationId(command.getParameters().getCorrelationId());
Line 1301: returnValue.setJobId(command.getJobId());
Line 1302: return returnValue;
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 171: }
Line 172: // set the _isRerun flag to false before calling
executeAction so that we'll know if
Line 173: // there is another rerun attempt within the method
Line 174: _isRerun = false;
Line 175: insertAsyncTaskPlaceHolders();
not sure why this is called here, i dont think tasks are created on rerun
Line 176: executeAction();
Line 177:
Line 178: // if there was no rerun attempt in the previous
executeAction call and the command
Line 179: // wasn't done because canDoAction check returned false..
--
To view, visit http://gerrit.ovirt.org/15561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66628b98298ed1f500946889604ad906f0a68022
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
