Mike Kolesnik has posted comments on this change.
Change subject: core: Introducing Batch updates to DAOs
......................................................................
Patch Set 14: (1 inline comment)
Looks good, but as Allon mentioned earlier, you can use java 7 syntax for
generics initialization.
It is already used in many other places and poses no risk.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
Line 112: } catch (SQLException e) {
Line 113: log.fatalFormat("Can't get procedure %s meta data",
Line 114: procName);
Line 115: log.fatal(e.getMessage(), e);
Line 116: } finally {
You can use java 7 syntax here, to close the resource
Line 117: rs2.close();
Line 118: }
Line 119:
Line 120:
procMetaData.setSqlCommand(handler.getDialect().createSqlCallCommand(
--
To view, visit http://gerrit.ovirt.org/15039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5ee0aa90bca3b5c257beb7b0eaa236f02f0206f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
