Kanagaraj M has posted comments on this change.
Change subject: gluster: Show host name also on action on services
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
Line 238: addCustomValue(GlusterConstants.CLUSTER,
getVdsGroupName());
Line 239: }
Line 240: addCustomValue(GlusterConstants.SERVICE_TYPE,
getParameters().getServiceType().name());
Line 241:
Line 242: return super.getCustomValues();
no need to override this method, instead you can add the custom values in
executeCommand method itself.
Line 243: }
Line 244:
Line 245: @Override
Line 246: protected Map<String, Pair<String, String>> getExclusiveLocks() {
--
To view, visit http://gerrit.ovirt.org/15718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic840e8e20a28e31ba79ee17eabf201fe3941ce7d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
