Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: Show host name also on action on services
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
Line 235: addCustomValue(GlusterConstants.SERVER, getVdsName());
Line 236: }
Line 237: if (clusterId != null) {
Line 238: addCustomValue(GlusterConstants.CLUSTER,
getVdsGroupName());
Line 239: }
Yes will set the service type only as custom value
Line 240: addCustomValue(GlusterConstants.SERVICE_TYPE,
getParameters().getServiceType().name());
Line 241:
Line 242: return super.getCustomValues();
Line 243: }
Line 238: addCustomValue(GlusterConstants.CLUSTER,
getVdsGroupName());
Line 239: }
Line 240: addCustomValue(GlusterConstants.SERVICE_TYPE,
getParameters().getServiceType().name());
Line 241:
Line 242: return super.getCustomValues();
yes, will set the service type only from executeCommand() method and would use
VdsName and VdsGroupName for server name and cluster name
Line 243: }
Line 244:
Line 245: @Override
Line 246: protected Map<String, Pair<String, String>> getExclusiveLocks() {
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 631: GLUSTER_SERVICE_STOPPED=${servicetype} services stopped on host
${server} on cluster ${cluster}.
Line 632: GLUSTER_SERVICE_STOP_FAILED=Could not stop ${servicetype} service on
host ${server} on cluster ${cluster}.
Line 633: GLUSTER_SERVICES_LIST_NOT_FETCHED=Could not fetch list of services
from ${ServiceGroupType} named ${ServiceGroupName}.
Line 634: GLUSTER_SERVICE_RESTARTED=${servicetype} service re-started on host
${server} on cluster ${cluster}.
Line 635: GLUSTER_SERVICE_RESTART_FAILED=Could not re-start ${servicetype}
service on host ${server} on cluster ${cluster}.
Yes, will do the changes accordingly
--
To view, visit http://gerrit.ovirt.org/15718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic840e8e20a28e31ba79ee17eabf201fe3941ce7d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
