Sandro Bonazzola has posted comments on this change. Change subject: [WIP] packaging: Added postgres listening external network ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/common_utils.py Line 536: ) Line 537: Line 538: password = askQuestion( Line 539: question='Provide a password for read-only user' Line 540: ) I think it is better if you use getpass for getting the password. Line 541: Line 542: # TODO: Do we have permissions for the following?? Line 543: configurePostgres(user) Line 544: createDbUser( Line 545: db_dict=db_dict, Line 546: user=user, Line 547: password=password Line 548: ) Line 549: configureIptables() What about FirewallD ? Line 550: Line 551: def configurePostgres(user): Line 552: postgresConf = '/var/lib/pgsql/data/postgresql.conf' Line 553: pgHba = '/var/lib/pgsql/data/pg_hba.conf' -- To view, visit http://gerrit.ovirt.org/15964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdd133a392fb3dba6088a9fb12ce4ca828f24073 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
