Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: NPE on PoolListModel ......................................................................
webadmin: NPE on PoolListModel The 1cf05c520c3e30f68ac12b5772a251aa78d46bbd did bring a regression because it expected that the disks can not be null, but they actually can be. Added a null check. Change-Id: I9f26ef2ab847cfec13bf13852e7c0647889183cb Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/15974/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java index 16b8990..0c65115 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java @@ -52,6 +52,11 @@ public void setDisks(List<DiskModel> value) { disks = value; + + if (disks == null) { + return; + } + sortDisks(); for (final DiskModel diskModel : disks) { -- To view, visit http://gerrit.ovirt.org/15974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f26ef2ab847cfec13bf13852e7c0647889183cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
