Tomas Jelinek has posted comments on this change. Change subject: webadmin: NPE on PoolListModel ......................................................................
Patch Set 2: Verified; Looks good to me, approved I rather left the null check in sortDisks - this already caused one NPE and since it is a public method it should guard it's invariants by itself - we can never know who will call it... -- To view, visit http://gerrit.ovirt.org/15974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f26ef2ab847cfec13bf13852e7c0647889183cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
