Alon Bar-Lev has posted comments on this change.
Change subject: utils: introduce EngineSSHClient wrapper
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHClient.java
Line 53: throw new IOException("Unable to parse host key");
Line 54: }
Line 55:
Line 56: return fingerprint;
Line 57: }
What?!?! I expect something like:
public void setVds(VDS vds) {
_vds = vds;
setHost(vds.fqdn);
}
public void connect() {
super.connect();
if (_vds != null) {
if (empty(_vds.fingerprint)) {
_vds.fingerprint = getHostFingerprint();
_vds.store();
}
else {
if (!_vds.fingerprint.equals(getHostFingerprint()) {
throw new GeneralSecurityException("Invalid fingerprint got X
exected Y");
}
}
}
}
Line 58:
Line 59: /**
Line 60: * Use default engine ssh key.
Line 61: */
--
To view, visit http://gerrit.ovirt.org/15969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1993ac7e01963135aa8f53ce481b308b6531ecd3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
