Yair Zaslavsky has posted comments on this change.
Change subject: utils: introduce EngineSSHClient wrapper
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
Alon - my question was minor.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHClient.java
Line 66: final String alias = config.getPKIEngineStoreAlias();
Line 67:
Line 68: KeyStore.PrivateKeyEntry entry;
Line 69: InputStream in = null;
Line 70: try {
How does engine compile to you if you're not using JDK 1.7? Autoclosable and
new generics syntax is already used in code.
Line 71: in = new FileInputStream(p12);
Line 72: KeyStore ks = KeyStore.getInstance("PKCS12");
Line 73: ks.load(in, password);
Line 74:
--
To view, visit http://gerrit.ovirt.org/15969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1993ac7e01963135aa8f53ce481b308b6531ecd3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
