Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: added upgrade from legacy plugin
......................................................................
Patch Set 2: Fails
(1 inline comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/legacy.py
Line 43:
Line 44: def _set_firewall_manager(self):
Line 45: managers = []
Line 46: if self.services.exists('firewalld'):
Line 47: if self._isPermanentSupported():
if it was enabled by legacy, it was supported. removing.
Line 48: managers.append('firewalld')
Line 49: if self.services.exists('iptables'):
Line 50: managers.append('iptables')
Line 51: for manager in managers:
--
To view, visit http://gerrit.ovirt.org/15975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee25f561218d83c5a4bd821c2d89587df5bc47a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
