Yaniv Bronhaim has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 369: if
(getParameters().getvds().getSSHKeyFingerprint().isEmpty()) {
Line 370: sshclient.setVds(getParameters().getvds());
Line 371: try {
Line 372:
getParameters().getvds().setSSHKeyFingerprint(sshclient.getHostFingerprint());
Line 373:
DbFacade.getInstance().getVdsStaticDao().save(getParameters().getVdsStaticData());
We talked about it.. from utils i can't reach the db to save the changes.
Line 374: } catch (Exception e) {
Line 375: log.warnFormat(
Line 376: "couldn't set fingerprint for vds",
Line 377: e);
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHClient.java
Line 54: super.connect();
Line 55: if (vdsClient != null) {
Line 56: String hostfp = getHostFingerprint();
Line 57: if (!vdsClient.getSSHKeyFingerprint().equals(hostfp)) {
Line 58: throw new GeneralSecurityException("Invalid
fingerprint got " +
can't do the persist part from here.
Line 59:
vdsClient.getSSHKeyFingerprint() +
Line 60: " exected " +
hostfp);
Line 61: }
Line 62: }
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
