Yair Zaslavsky has posted comments on this change.
Change subject: Wrap validation of fingerprint in each connect using
EngineSSHClient
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 368: if
(getParameters().getvds().getSSHKeyFingerprint().isEmpty()) {
Line 369: sshclient.setVds(getParameters().getvds());
Line 370: try {
Line 371:
getParameters().getvds().setSSHKeyFingerprint(sshclient.getHostFingerprint());
Line 372:
DbFacade.getInstance().getVdsStaticDao().save(getParameters().getVdsStaticData());
please use "getVdsStaticDao()" and not a direct evil singleton :)
Line 373: } catch (Exception e) {
Line 374: log.warnFormat(
Line 375: "couldn't set fingerprint for vds",
Line 376: e);
--
To view, visit http://gerrit.ovirt.org/16126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01517a153406c8bafc672c20b0bf8686763a2f5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
