Alexander Wels has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 686: Date dateISO = format.parse(formattedISOVersion);
Line 687: // Split by . nodeInfo[2] and get the first element.
Example: 20120228.fc18
Line 688: Date dateNodeISO =
format.parse(nodeInfo[2].split("\\.")[0].trim()); //$NON-NLS-1$
Line 689: if (dateISO.compareTo(dateNodeISO)>0) {
Line 690: alert = true;
I disagree, you should try to have one exit point from a method. Which is
exactly what he is doing here.
Line 691: break;
Line 692: }
Line 693: } catch (IllegalArgumentException er) {
Line 694: logger.info("IllegalArgumentException error: " + er);
//$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
