Douglas Schilling Landgraf has posted comments on this change.
Change subject: HostGeneralModel: improve "node has upgrade" logic
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 47: {
Line 48: private static final UIConstants constants =
ConstantsManager.getInstance().getConstants();
Line 49: private static final UIMessages messages =
ConstantsManager.getInstance().getMessages();
Line 50:
Line 51: private static final Logger logger =
Logger.getLogger(HostGeneralModel.class.getName());
Done
Line 52:
Line 53: public static EventDefinition RequestEditEventDefinition;
Line 54: private Event privateRequestEditEvent;
Line 55:
Line 674: public boolean shouldAlertUpgrade(ArrayList<RpmVersion> isos,
String hostOs)
Line 675: {
Line 676: boolean alert = false;
Line 677:
Line 678: DateTimeFormat format = DateTimeFormat.getFormat("yyyyMMdd");
//$NON-NLS-1$
Done
Line 679: String nodeInfo[] = hostOs.split("-"); //$NON-NLS-1$
Line 680: String formattedISOVersion = null;
Line 681: for (RpmVersion iso: isos) {
Line 682: try {
Line 676: boolean alert = false;
Line 677:
Line 678: DateTimeFormat format = DateTimeFormat.getFormat("yyyyMMdd");
//$NON-NLS-1$
Line 679: String nodeInfo[] = hostOs.split("-"); //$NON-NLS-1$
Line 680: String formattedISOVersion = null;
Done
Line 681: for (RpmVersion iso: isos) {
Line 682: try {
Line 683: formattedISOVersion = String.valueOf(iso);
Line 684: // Get last 8 chars which is the date. Example:
2.6.0.20130212
Line 679: String nodeInfo[] = hostOs.split("-"); //$NON-NLS-1$
Line 680: String formattedISOVersion = null;
Line 681: for (RpmVersion iso: isos) {
Line 682: try {
Line 683: formattedISOVersion = String.valueOf(iso);
Done
Line 684: // Get last 8 chars which is the date. Example:
2.6.0.20130212
Line 685: formattedISOVersion =
formattedISOVersion.substring(formattedISOVersion.length() - 8);
Line 686: Date dateISO = format.parse(formattedISOVersion);
Line 687: // Split by . nodeInfo[2] and get the first element.
Example: 20120228.fc18
Line 686: Date dateISO = format.parse(formattedISOVersion);
Line 687: // Split by . nodeInfo[2] and get the first element.
Example: 20120228.fc18
Line 688: Date dateNodeISO =
format.parse(nodeInfo[2].split("\\.")[0].trim()); //$NON-NLS-1$
Line 689: if (dateISO.compareTo(dateNodeISO)>0) {
Line 690: alert = true;
My point is the same as Alexander shared.
Line 691: break;
Line 692: }
Line 693: } catch (IllegalArgumentException er) {
Line 694: logger.info("IllegalArgumentException error: " + er);
//$NON-NLS-1$
Line 689: if (dateISO.compareTo(dateNodeISO)>0) {
Line 690: alert = true;
Line 691: break;
Line 692: }
Line 693: } catch (IllegalArgumentException er) {
Done
Line 694: logger.info("IllegalArgumentException error: " + er);
//$NON-NLS-1$
Line 695: }
Line 696: }
Line 697: return alert;
Line 693: } catch (IllegalArgumentException er) {
Line 694: logger.info("IllegalArgumentException error: " + er);
//$NON-NLS-1$
Line 695: }
Line 696: }
Line 697: return alert;
The same point as Alexander shared.
Line 698: }
Line 699:
Line 700: private boolean hasManualFenceAlert;
Line 701:
--
To view, visit http://gerrit.ovirt.org/16089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49c74d3d0d92c74848e0c175095610b6e6b5a88e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
