Maor Lipchuk has posted comments on this change.
Change subject: Adding ssh_user and ssh_port values to api schema for Host
mapper
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 104: if (action.isSetImage()) {
Line 105: params.setoVirtIsoFile(action.getImage());
Line 106: }
Line 107: } else {
Line 108: validateParameters(action, "Password");
Don't you want to validate password here (With a lower case) same as you use in
BackendHostsResource
Line 109: }
Line 110: return doAction(VdcActionType.UpdateVds,
Line 111: params,
Line 112: action);
--
To view, visit http://gerrit.ovirt.org/16247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b8c117d041c29780af2468888a732ee664d283c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
