Michael Pasternak has posted comments on this change.
Change subject: Adding ssh_user and ssh_port values to api schema for Host
mapper
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(10 inline comments)
please update rsdl_metadata.yaml accordingly
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 907: <column>vds_unique_id</column>
Line 908: <column>host_name</column>
Line 909: <column>port</column>
Line 910: <column>ssh_port</column>
Line 911: <column>ssh_username</column>
this file is not a part of the api, i'd suggest taking it out of this change.
Line 912: <column>vds_group_id</column>
Line 913: <column>server_SSL_enabled</column>
Line 914: <column>vds_type</column>
Line 915: <column>vds_strength</column>
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 140
Line 141
Line 142
Line 143
Line 144
this change is a api break, please revert it and add ref="user" as described
bellow
Line 1258: <!-- unsigned to avoid issues with port values greater
than 32767,
Line 1259: e.g. the standard VDSM port 54321 -->
Line 1260: <xs:element name="port" type="xs:unsignedShort"
minOccurs="0"/>
Line 1261: <xs:element name="ssh_port" type="xs:unsignedShort"
minOccurs="0"/>
Line 1262: <xs:element name="ssh_username" type="xs:string"
minOccurs="0"/>
host has "root_password", it not exactly fits now, but we have to
keep it in sake of backward compatibility,
instead of this change please add reference to "user" type, it has both
username/password and make sure it's also used for "root_password" (as
alternative),
this way we will deprecate "root_password" and will be using
host.user.username|password in
future
Line 1263: <xs:element name="type" type="xs:string" minOccurs="0"/>
Line 1264: <xs:element name="storage_manager" type="StorageManager"
minOccurs="0"/>
Line 1265: <xs:element name="version" type="Version" minOccurs="0"/>
Line 1266: <xs:element ref="hardware_information" minOccurs="0"/>
Line 1265
Line 1266
Line 1267
Line 1268
Line 1269
this change is a api break, please revert it.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
Line 104: if (action.isSetImage()) {
Line 105: params.setoVirtIsoFile(action.getImage());
Line 106: }
Line 107: } else {
Line 108: validateParameters(action, "Password");
please revert these changes (expl in api.xsd)
Line 109: }
Line 110: return doAction(VdcActionType.UpdateVds,
Line 111: params,
Line 112: action);
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java
Line 88: validateEnums(Host.class, host);
Line 89: validateParameters(host, "name", "address", "password");
Line 90: VdsStatic staticHost = getMapper(Host.class,
VdsStatic.class).map(host, null);
Line 91: staticHost.setVdsGroupId(getClusterId(host));
Line 92: AddVdsActionParameters addParams = new
AddVdsActionParameters(staticHost, host.getPassword());
please revert these changes (expl in api.xsd)
Line 93: if (host.isSetOverrideIptables()) {
Line 94: addParams.setOverrideFirewall(host.isOverrideIptables());
Line 95: }
Line 96: if (host.isSetRebootAfterInstallation()) {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java
Line 450: new String[] {
"RootPassword" },
Line 451: new Object[] { NAMES[2]
}));
Line 452:
Line 453: Action action = new Action();
Line 454: action.setPassword(NAMES[2]);
please revert these changes (expl in api.xsd)
Line 455: verifyActionResponse(resource.install(action));
Line 456: }
Line 457:
Line 458: @Test
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java
Line 340: static Host getModel(int index) {
Line 341: Host model = new Host();
Line 342: model.setName(NAMES[index]);
Line 343: model.setAddress(ADDRESSES[index]);
Line 344: model.setPassword(ROOT_PASSWORD);
please revert these changes (expl in api.xsd)
Line 345: return model;
Line 346: }
Line 347:
Line 348: @Override
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
Line 69: new Object[] { NAMES[2],
"Some-Correlation-id" },
Line 70: true,
Line 71: true)));
Line 72: Action action = new Action();
Line 73: action.setPassword(NAMES[2]);
please revert these changes (expl in api.xsd)
Line 74: resource.install(action);
Line 75: }
Line 76:
Line 77: @Test(expected = MalformedIdException.class)
....................................................
Commit Message
Line 3: AuthorDate: 2013-06-30 10:44:34 +0300
Line 4: Commit: Yaniv Bronhaim <[email protected]>
Line 5: CommitDate: 2013-07-02 12:17:14 +0300
Line 6:
Line 7: Adding ssh_user and ssh_port values to api schema for Host mapper
this descr. lacking basic info, where it used?/why? etc.
Line 8:
Line 9: Change-Id: I6b8c117d041c29780af2468888a732ee664d283c
--
To view, visit http://gerrit.ovirt.org/16247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b8c117d041c29780af2468888a732ee664d283c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
