Alex Lourie has posted comments on this change. Change subject: packaging: added DB validation functions ......................................................................
Patch Set 6: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py Line 309: ) Line 310: def _validation(self): Line 311: runningTasks, compensations = self._checkRunningTasks() Line 312: if runningTasks or compensations: Line 313: self._askUserToStopTasks(runningTasks, compensations) no....it's exactly the same. We do not 'wait' for tasks at any stage. We first detect that there are tasks; and if there are tasks we ask user if he wants to clear them. If user wants to clear them, we put the engine into maintenance mode, set a vdcoption value to 0 (meaning we tell the engine all running tasks are zombies and need to be cleaned), and wait indefinitely until all tasks are cleared, asking a user whether he still wants to wait each 20 seconds. So clearing is waiting in our case. Line 314: Line 315: @plugin.event( Line 316: # NOTE: Line 317: # this must run before the package update -- To view, visit http://gerrit.ovirt.org/15970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
