Alon Bar-Lev has posted comments on this change. Change subject: packaging: added DB validation functions ......................................................................
Patch Set 6: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py Line 309: ) Line 310: def _validation(self): Line 311: runningTasks, compensations = self._checkRunningTasks() Line 312: if runningTasks or compensations: Line 313: self._askUserToStopTasks(runningTasks, compensations) yes, and I think this stage should be in validation, as as long as there are tasks we do not wish to install.... do you think validation will have unneeded side effects? Line 314: Line 315: @plugin.event( Line 316: # NOTE: Line 317: # this must run before the package update -- To view, visit http://gerrit.ovirt.org/15970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
