Maor Lipchuk has posted comments on this change.
Change subject: Using ssh username and password to install and update host
......................................................................
Patch Set 12: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 317: returnValue =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_WITH_SAME_HOST_EXIST);
Line 318: } else if
(!ValidationUtils.validatePort(vds.getSSHPort())) {
Line 319: returnValue =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_PORT);
Line 320: } else if ((vds.getSSHUsername() == null) ||
Line 321: vds.getSSHUsername().isEmpty() ||
Use StringUtils.isEmpty (of org.apache.commons.lang), instead both checks for
null and empty
Line 322: (vds.getSSHUsername().length() >
BusinessEntitiesDefinitions.HOST_HOSTNAME_SIZE)) {
Line 323: returnValue =
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_USERNAME);
Line 324: } else {
Line 325: returnValue = returnValue &&
validateSingleHostAttachedToLocalStorage();
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
Line 10:
Line 11: @Valid
Line 12: private VdsStatic _vdsStatic;
Line 13:
Line 14: private String _password;
You didn't respond to my comment from last patch, why not change the variable
name to password instead _password
Line 15:
Line 16: private boolean overrideFirewall;
Line 17:
Line 18: /**
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 516: -Please remove VLAN from the interface.
Line 517: NETWORK_ALREADY_ATTACHED_TO_CLUSTER=Logical Network is already
attached to Cluster.
Line 518: ACTION_TYPE_FAILED_VDS_WITH_SAME_HOST_EXIST=Cannot ${action} ${type}.
Host with the same address already exists.
Line 519: ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_PORT=Cannot ${action}
${type}. Invalid SSH port was entered.
Line 520: ACTION_TYPE_FAILED_VDS_WITH_INVALID_SSH_USERNAME=Cannot ${action}
${type}. Invalid SSH user-name was entered.
It should also be added in
/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
and in
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
also in the web admin
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
and probably in the tests
/home/mlipchuk/rhevm/backend/manager/modules/utils/src/test/resources/AppErrors.properties
Line 521: ACTION_TYPE_FAILED_VDS_WITH_SAME_UUID_EXIST=Cannot ${action} ${type}.
Host with the same UUID already exists.
Line 522: ACTION_TYPE_FAILED_ILLEGAL_MEMORY_SIZE=Cannot ${action} ${type}.
Illegal memory size is provided, size needs to be between ${minMemorySize} MB
and ${maxMemorySize} MB.
Line 523: ACTION_TYPE_FAILED_ILLEGAL_NUM_OF_MONITORS=Cannot ${action} ${type}.
Illegal number of monitors is provided, max allowed number of monitors is 1 for
VNC and the max number in the ValidNumOfMonitors configuration variable for
SPICE.
Line 524: ACTION_TYPE_FAILED_ILLEGAL_DOMAIN_NAME=Cannot ${action} ${type}.
Illegal Domain name: ${Domain}. Domain name has unsupported special character
${Char}.
--
To view, visit http://gerrit.ovirt.org/16006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39914e1286870373ad6f69360fa7b3ddfabd8df
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
