Daniel Erez has posted comments on this change. Change subject: Modifying Reinstall Host popup view ......................................................................
Patch Set 7: (7 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2013-06-25 18:06:23 +0300 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2013-07-02 12:17:15 +0300 Line 6: Line 7: Modifying Reinstall Host popup view add 'webadmin:' prefix Line 8: Line 9: 1. Adding password or publicKey fields for authentication. Line 10: 2. Adding ssh fingerprint field. Line 11: Line 9: 1. Adding password or publicKey fields for authentication. Line 10: 2. Adding ssh fingerprint field. Line 11: Line 12: Change-Id: Iff04dc81d4d2f9f7859060dcc44e7c9a59f4c03f Line 13: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=848072 remove bug url .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java Line 90: setUserName(new EntityModel()); Line 91: getUserName().setEntity(constants.defaultUserName()); Line 92: setPublicKey(new EntityModel()); Line 93: getPublicKey().setEntity(constants.empty()); Line 94: fetchPublicKey(); is it always mandatory to fetch the key? if not, it's better to call it manually rather than in the ctr... Line 95: } Line 96: Line 97: public boolean validate(boolean isOVirt) { Line 98: getOVirtISO().setIsValid(true); .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java Line 127: public void edit(final InstallModel model) { Line 128: driver.edit(model); Line 129: Line 130: rbPassword.setValue(true); Line 131: passwordEditor.getElement().getStyle().setVisibility(Visibility.VISIBLE); please extract this to a method Line 132: publicKeyEditor.getElement().getStyle().setVisibility(Visibility.HIDDEN); Line 133: Line 134: rbPassword.addValueChangeHandler(new ValueChangeHandler<Boolean>() { Line 135: @Override Line 133: Line 134: rbPassword.addValueChangeHandler(new ValueChangeHandler<Boolean>() { Line 135: @Override Line 136: public void onValueChange(ValueChangeEvent<Boolean> event) { Line 137: passwordEditor.getElement().getStyle().setVisibility(Visibility.VISIBLE); same Line 138: publicKeyEditor.getElement().getStyle().setVisibility(Visibility.HIDDEN); Line 139: } Line 140: }); Line 141: Line 141: Line 142: rbPublicKey.addValueChangeHandler(new ValueChangeHandler<Boolean>() { Line 143: @Override Line 144: public void onValueChange(ValueChangeEvent<Boolean> event) { Line 145: publicKeyEditor.getElement().getStyle().setVisibility(Visibility.VISIBLE); same Line 146: passwordEditor.getElement().getStyle().setVisibility(Visibility.HIDDEN); Line 147: } Line 148: }); Line 149: } .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.ui.xml Line 41: width: 450px; Line 42: } Line 43: Line 44: .content { Line 45: width:100%; formatter Line 46: } Line 47: </ui:style> Line 48: Line 49: <d:SimpleDialogPanel width="500px" height="250px"> -- To view, visit http://gerrit.ovirt.org/16174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff04dc81d4d2f9f7859060dcc44e7c9a59f4c03f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
