Daniel Erez has posted comments on this change.
Change subject: Modifying Reinstall Host popup view
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java
Line 90: setUserName(new EntityModel());
Line 91: getUserName().setEntity(constants.defaultUserName());
Line 92: setPublicKey(new EntityModel());
Line 93: getPublicKey().setEntity(constants.empty());
Line 94: fetchPublicKey();
I've just meant that maybe we should invoke this method from the list model,
but if it's mandatory to obtain the publickey then I guess it's fine to keep it
here. Please verify that this model is not created in any other context (which
doesn't require the publickey..).
Line 95: }
Line 96:
Line 97: public boolean validate(boolean isOVirt) {
Line 98: getOVirtISO().setIsValid(true);
--
To view, visit http://gerrit.ovirt.org/16174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff04dc81d4d2f9f7859060dcc44e7c9a59f4c03f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
