Allon Mureinik has uploaded a new change for review. Change subject: core: Extract VmPoolMapRowMapper ......................................................................
core: Extract VmPoolMapRowMapper Extracted VmPoolMapRowMapper in VmPoolDAODbFacadeImpl as per the backend's coding conventions. Change-Id: I8ad16cf87574ac1a8f74b15fd0d2188b4c2083d2 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java 1 file changed, 15 insertions(+), 33 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/16389/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java index 6732aec..3e53636 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java @@ -115,17 +115,7 @@ public VmPoolMap getVmPoolMapByVmGuid(Guid vmId) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("vm_guid", vmId); - RowMapper<VmPoolMap> mapper = new RowMapper<VmPoolMap>() { - @Override - public VmPoolMap mapRow(ResultSet rs, int rowNum) throws SQLException { - VmPoolMap entity = new VmPoolMap(); - entity.setvm_guid(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_guid"))); - entity.setvm_pool_id(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_pool_id"))); - return entity; - } - }; - - return getCallsHandler().executeRead("GetVm_pool_mapByvm_guid", mapper, parameterSource); + return getCallsHandler().executeRead("GetVm_pool_mapByvm_guid", VmPoolMapRowMapper.instance, parameterSource); } @Override @@ -140,17 +130,7 @@ public List<VmPoolMap> getVmPoolsMapByVmPoolId(Guid vmPoolId) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource().addValue("vm_pool_id", vmPoolId); - RowMapper<VmPoolMap> mapper = new RowMapper<VmPoolMap>() { - @Override - public VmPoolMap mapRow(ResultSet rs, int rowNum) throws SQLException { - VmPoolMap entity = new VmPoolMap(); - entity.setvm_guid(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_guid"))); - entity.setvm_pool_id(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_pool_id"))); - return entity; - } - }; - - return getCallsHandler().executeReadList("GetVm_pool_mapByvm_pool_id", mapper, parameterSource); + return getCallsHandler().executeReadList("GetVm_pool_mapByvm_pool_id", VmPoolMapRowMapper.instance, parameterSource); } @Override @@ -159,17 +139,7 @@ getCustomMapSqlParameterSource().addValue("vm_pool_id", vmPoolId).addValue("status", vmStatus.getValue()); - RowMapper<VmPoolMap> mapper = new RowMapper<VmPoolMap>() { - @Override - public VmPoolMap mapRow(ResultSet rs, int rowNum) throws SQLException { - VmPoolMap entity = new VmPoolMap(); - entity.setvm_guid(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_guid"))); - entity.setvm_pool_id(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_pool_id"))); - return entity; - } - }; - - return getCallsHandler().executeReadList("getVmMapsInVmPoolByVmPoolIdAndStatus", mapper, + return getCallsHandler().executeReadList("getVmMapsInVmPoolByVmPoolIdAndStatus", VmPoolMapRowMapper.instance, parameterSource); } @@ -221,6 +191,18 @@ } } + private static final class VmPoolMapRowMapper implements RowMapper<VmPoolMap> { + public static final VmPoolMapRowMapper instance = new VmPoolMapRowMapper(); + + @Override + public VmPoolMap mapRow(ResultSet rs, int rowNum) throws SQLException { + VmPoolMap entity = new VmPoolMap(); + entity.setvm_guid(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_guid"))); + entity.setvm_pool_id(Guid.createGuidFromStringDefaultEmpty(rs.getString("vm_pool_id"))); + return entity; + } + } + @Override public VM getVmDataFromPoolByPoolGuid(Guid vmPoolId, Guid userID, boolean isFiltered) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() -- To view, visit http://gerrit.ovirt.org/16389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ad16cf87574ac1a8f74b15fd0d2188b4c2083d2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
