Alona Kaplan has posted comments on this change.
Change subject: webadmin: Redesigned Discovery popup
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
Line 171: // Configure table selection model
Line 172: switch (selectionMode) {
Line 173: case MULTIPLE:
Line 174: setSelectionModel(new MultiSelectionModel<EntityModel>(),
Line 175: new DefaultSelectionEventManager<EntityModel>(new
DefaultSelectionEventManager.CheckboxEventTranslator<EntityModel>(0)) {});
1. Please move the changes in this class to a separate patch and add Vojtech as
reviewer.
2. You can use DefaultSelectionEventManager.<EntityModel>
createCheckboxManager(0))
Line 176: break;
Line 177: case NONE:
Line 178: setSelectionModel(new NoSelectionModel<EntityModel>());
Line 179: break;
Line 273: && !(getSelectionModel() instanceof
NoSelectionModel)) {
Line 274: // Let elements who can deal with the event
deal with it
Line 275: Element target =
event.getNativeEvent().getEventTarget().cast();
Line 276: String tagName =
target.getTagName().toLowerCase();
Line 277: if ("input".equals(tagName) ||
"select".equals(tagName) || "option".equals(tagName)) { //$NON-NLS-1$
$NON-NLS-2$ $NON-NLS-3$
I have two problem with this code-
1. If effect all the EntityModelCellTable in the system.
2. I think this code is not generic enough. If you"ll add another editable
element to the column you"ll have to refactor this code.
You can add a "raiseSelectionWhenClicked" property to the column. This property
can be true by default (So you won't effect other tables in the system). If it
is set to false, return here instead of setting the selection.
Line 278: return;
Line 279: }
Line 280:
getSelectionModel().setSelected(event.getValue(),
Line 281:
!getSelectionModel().isSelected(event.getValue()));
--
To view, visit http://gerrit.ovirt.org/16069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I013e125c3e0f6dba91addb55727904904faf8164
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
