Lior Vernia has posted comments on this change.
Change subject: webadmin: Redesigned Discovery popup
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
Line 171: // Configure table selection model
Line 172: switch (selectionMode) {
Line 173: case MULTIPLE:
Line 174: setSelectionModel(new MultiSelectionModel<EntityModel>(),
Line 175: new DefaultSelectionEventManager<EntityModel>(new
DefaultSelectionEventManager.CheckboxEventTranslator<EntityModel>(0)) {});
Done
Line 176: break;
Line 177: case NONE:
Line 178: setSelectionModel(new NoSelectionModel<EntityModel>());
Line 179: break;
Line 273: && !(getSelectionModel() instanceof
NoSelectionModel)) {
Line 274: // Let elements who can deal with the event
deal with it
Line 275: Element target =
event.getNativeEvent().getEventTarget().cast();
Line 276: String tagName =
target.getTagName().toLowerCase();
Line 277: if ("input".equals(tagName) ||
"select".equals(tagName) || "option".equals(tagName)) { //$NON-NLS-1$
$NON-NLS-2$ $NON-NLS-3$
Rather than an HTML property, implemented as an interface that includes a
method handleEvent(). Column cells may implement the interface, and decide in
which cases they prefer to handle their own events.
Line 278: return;
Line 279: }
Line 280:
getSelectionModel().setSelected(event.getValue(),
Line 281:
!getSelectionModel().isSelected(event.getValue()));
--
To view, visit http://gerrit.ovirt.org/16069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I013e125c3e0f6dba91addb55727904904faf8164
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
